Skip to content

Attributes all #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 10, 2020
Merged

Attributes all #690

merged 6 commits into from
Dec 10, 2020

Conversation

@tomvanmele
Copy link
Member

@tomvanmele tomvanmele commented Dec 7, 2020

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@tomvanmele tomvanmele linked an issue Dec 7, 2020 that may be closed by this pull request
Mesh.face_attributes does not return all attributes #689
Closed
@tomvanmele
Copy link
Member Author

tomvanmele commented Dec 7, 2020

the problem lies in the __iter__ method of AttributeView. it only looks at the defaults even though all of the other methods look in both. as a result all mapping methods of MutableMapping return key, items, values only from the defaults dict...

@tomvanmele
Copy link
Member Author

tomvanmele commented Dec 7, 2020

not sure if the proposed solution is the simplest possible though...

beverlylytle
beverlylytle reviewed Dec 7, 2020
View reviewed changes
src/compas/datastructures/attributes.py
Comment on lines +51 to +52
names = set(self.defaults).union(self.attr)
for name in names:
Copy link
Member

@beverlylytle beverlylytle Dec 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should __len__ reflect this change?

Copy link
Member Author

@tomvanmele tomvanmele Dec 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes indeed it should

@tomvanmele
Copy link
Member Author

tomvanmele commented Dec 8, 2020

@gonzalocasas ping

@gonzalocasas
Copy link
Member

gonzalocasas commented Dec 9, 2020

lgtm! if build is green, go for it

@gonzalocasas
Copy link
Member

gonzalocasas commented Dec 10, 2020

@brgcode merge?

@tomvanmele tomvanmele merged commit 5fc5cb3 into master Dec 10, 2020
@gonzalocasas gonzalocasas deleted the attributes-all branch December 10, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beverlylytle beverlylytle beverlylytle left review comments

@gonzalocasas gonzalocasas Awaiting requested review from gonzalocasas

@Licini Licini Awaiting requested review from Licini

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mesh.face_attributes does not return all attributes

4 participants

@tomvanmele @gonzalocasas @beverlylytle