-
Notifications
You must be signed in to change notification settings - Fork 113
Prepend libs to path #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepend libs to path #720
Conversation
src/compas/_os.py
Outdated
| if is_windows(): | ||
| lib_bin = os.path.join(PYTHON_DIRECTORY, 'Library', 'bin') | ||
| if os.path.exists(lib_bin) and lib_bin not in env['PATH']: | ||
| env['PATH'] = lib_bin + os.pathsep + env['PATH'] | ||
|
|
||
| else: | ||
| lib_bin = os.path.join(PYTHON_DIRECTORY, 'bin') | ||
| if os.path.exists(lib_bin) and lib_bin not in env['PATH']: | ||
| env['PATH'] = lib_bin + os.pathsep + env['PATH'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be preferable?
| if is_windows(): | |
| lib_bin = os.path.join(PYTHON_DIRECTORY, 'Library', 'bin') | |
| if os.path.exists(lib_bin) and lib_bin not in env['PATH']: | |
| env['PATH'] = lib_bin + os.pathsep + env['PATH'] | |
| else: | |
| lib_bin = os.path.join(PYTHON_DIRECTORY, 'bin') | |
| if os.path.exists(lib_bin) and lib_bin not in env['PATH']: | |
| env['PATH'] = lib_bin + os.pathsep + env['PATH'] | |
| if is_windows(): | |
| lib_bin = os.path.join(PYTHON_DIRECTORY, 'Library', 'bin') | |
| else: | |
| lib_bin = os.path.join(PYTHON_DIRECTORY, 'bin') | |
| if os.path.exists(lib_bin) and lib_bin not in env['PATH']: | |
| env['PATH'] = lib_bin + os.pathsep + env['PATH'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.