Polyline fixes #804
Merged
Polyline fixes #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beverlylytle
approved these changes
Mar 30, 2021
Member
beverlylytle
left a comment
beverlylytle
left a comment
There was a problem hiding this comment.
Looks good! Just the one comment to address, and then we merge!
| return self.divide_polyline_by_length(segment_length, False) | ||
|
|
||
| def divide_polyline_by_length(self, length, strict=True): | ||
| def divide_polyline_by_length(self, length, strict=True, tol=1e-06): |
Member
There was a problem hiding this comment.
Add tol to the parameters list in the docstring, please...
Member
There was a problem hiding this comment.
oh, also, there shouldn't be blank lines between the parameters... it makes the docs look funny... see https://compas.dev/compas/latest/api/generated/compas.geometry.Polyline.divide_polyline_by_length.html#compas.geometry.Polyline.divide_polyline_by_length
Contributor
Author
There was a problem hiding this comment.
just fyi, in offset_polyline tol isn't referenced!
compas/src/compas/geometry/offset/offset.py
Line 125 in be55894
Will make the changes though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).