Skip to content

Conversation

@beverlylytle
Copy link
Member

The componentizer action expects that there are no directories in the component directories outside of the actual components (I'm not sure of the vocabulary here. Everything seems to be called a component.) So, when invoke build_ghuser_components is called when the ghuser folder exists there, an error is raised. This PR is to remove that folder at the start of the build_ghuser_components task.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@beverlylytle beverlylytle merged commit 75072d9 into main Jun 9, 2021
@beverlylytle beverlylytle deleted the cleanup_ghuser branch June 9, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants