-
Notifications
You must be signed in to change notification settings - Fork 113
Datastructures Restructure #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
by using the "IPY guard" where necessary, i would like to add all data structure algorithms to the corresponding classes. this would simplify many things
one potential advantage is also that all algorithms and their dependencies don't have to be pre-loaded at the 2nd level. however, this requires the imports at the class level to be integrated at the method level. otherwise everything is again automatically loaded when the class is loaded... opinions? |
gonzalocasas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.