Add Halfface element queries #911
Conversation
Include queries (where and predicates) for composing elements of VolMesh. Consistent with Mesh datastructure query functions.
tomvanmele
left a comment
tomvanmele
left a comment
There was a problem hiding this comment.
this seems very testable. please add some :)
tomvanmele
left a comment
tomvanmele
left a comment
There was a problem hiding this comment.
generally looking good, but could you add a few test?
|
@brgcode could you pls take a look at this again and confirm if it's good to go? |
it never was, but i seem to have forgotten to submit my review... |
| for u in cell[c]: | ||
| for v in cell[c][u]: | ||
| faces.append(cell[c][u][v]) | ||
| faces.append(cell[c][u][v]) |
There was a problem hiding this comment.
why is this loop removed? this cannot possibly be expected to yield the same result...
There was a problem hiding this comment.
wrongly left out one loop when changing halfface data init, reverted this to main now.
| def index_vertex(self): | ||
| """Returns a dictionary that maps the indices of a vertex list to | ||
| keys in the vertex dictionary. | ||
| keys in a vertex dictionary. |
There was a problem hiding this comment.
should be "the", since it refers to "the" vertex dictionary used for internal storage, not "a" random vertex dictionary
There was a problem hiding this comment.
ok, shall we update the same in docstring of halfedge key_index() method.
| key: hashable | ||
| The next vertex that matches the condition. | ||
| 2-tuple | ||
| The next vertex and its attributes, if ``data=True``. |
|
@Sam-Bouten can you update your |
tomvanmele
left a comment
tomvanmele
left a comment
There was a problem hiding this comment.
can you remove the double backticks from the docstrings, please?
reference to a parameter name is
`param`
and True and False are without anything...
4 participants
Included queries (_where and _where_predicate) for elements of VolMesh (halfface.py),
that up until now were placeholders or had no interface declared.
Consistent with the Mesh datastructure (halfedge.py) query functions.
resolves issue #906.
What type of change is this?
Checklist
CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.