Skip to content

Conversation

@gonzalocasas
Copy link
Member

@gonzalocasas gonzalocasas commented Dec 11, 2021

One of the recently renamed functions was still used in tasks.py but instead of fixing that, I changed the way this was done and instead of locating the GH_IO.dll file on the local install, I changed to fetching it from NuGet (which is what we actually do on the github action build steps anyway, but we do that using the action, which relies on .NET NuGet to get it).
I did add a retroactive note of the change in the changelog

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@gonzalocasas gonzalocasas requested review from a user and tomvanmele December 11, 2021 13:48
Copy link
Member

@tomvanmele tomvanmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gonzalocasas gonzalocasas merged commit 3912bcb into main Dec 11, 2021
@gonzalocasas gonzalocasas deleted the fix-build-ghuser-components branch December 11, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants