Fix Trajectory data backward compatibility#311
Merged
beverlylytle merged 5 commits intoJun 22, 2021
Conversation
10 tasks
Member
gonzalocasas
left a comment
There was a problem hiding this comment.
LGTM!
@beverlylytle wanna give it a look in case I'm missing something?
Member
|
LGTM, too! The deploy-and-publish workflow is failing because one of the links is broken/dead. Maybe replace the link in line compas_fab/src/compas_fab/robots/wrench.py Line 376 in 53a053e |
Contributor
Author
|
@beverlylytle I pushed another change to fix the link, now it seems to be good to go? |
Member
|
Yep, it is! Thanks for improving the code! |
beverlylytle
approved these changes
Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of change is this?
This PR includes a small fix to make
compas_fab.robots.JointTrajectory's from_data compatible with json data generated beforecompas_fab 0.18.0, before theJointTrajectoryPointclass attributesvaluesandtypesare changed tojoint_valuesandjoint_types, and theattached_collision_meshesattribute is introduced.While I am very eager to try out all the exciting features introduced in the latest version, I found upgrading the version turned all of my previously saved
JointTrajectorydata unparsable. I understand that we cannot keep compatible with everything in the past, but I found being backward-compatible for a longer time period can be very beneficial.This PR also includes a small fix to disable
redirect_stdoutwhen used in a Jupyter notebook environment. Jupyter notebook (ipython) will raiseUnsupportedOperationonfileno(): ipython/ipython#3072. I suggest we can simply circumventredirect_stdoutsince C output is hidden anyway by default in ipython, unless we use some external piping package like https://github.com/minrk/wurlitzer.This PR is also related to compas-dev/compas#867
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.rstfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas_fab.robots.CollisionMesh.