Adds Frame support to scene rendering and geometry conversions
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces functionality to visualize frames as 3D objects in the Notebook Viewer. - Adds a `frame_to_threejs` conversion utility for transforming frames into PyThreeJS objects. - Implements `ThreeFrameObject` for rendering frames in scenes, with axes visualized in red, green, and blue. - Updates the registration process to include frame objects in the Notebook Viewer. - Enhances the example notebook to demonstrate frame rendering capabilities. - Fixes a type annotation issue in `line_to_threejs` and improves the `draw` method's return type annotations for consistency. These changes enhance the visualization capabilities of the Notebook Viewer and improve type safety in the codebase.
Contributor
Author
|
superseded by #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces functionality for handling
Frameobjects in the notebook environment:frame_to_threejsmethod to convertFrameobjects to PyThreeJS geometries.Frameobjects in the scene rendering pipeline.Framerendering.__all__definitions to clean up the code.line_to_threejsThis enhancement improves visualization capabilities by enabling the rendering of frames with distinct axes in 3D scenes.