-
Notifications
You must be signed in to change notification settings - Fork 7
Allow no support package in LocalPackageMeshLoader #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yck011522
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the interest of not changing signature, I did not change the init signature to have support_package = None
gonzalocasas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test to verify that this works, because I see there are calls to build_path that rely on support_package being there and while they will still work now, it feels a bit fragile.
yck011522
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test to verify that this works, because I see there are calls to
build_paththat rely onsupport_packagebeing there and while they will still work now, it feels a bit fragile.
I can see that there are calls to build_path , maybe I should make a switch there too to not include support_package if it is empty.
Regarding test, I'm not sure what you are refering to as fragile, can you elaborate more or explain how you would design the test? @gonzalocasas
This will allow the LocalPackageMeshLoader to process robot
packages that does not have a support_package sub folder. This is used for loading packages from the local_cache_directory of the RosFileServerLoader.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).