Skip to content

fix(store): flush file deletion batches while iterating in jobFileCleanup#4058

Merged
dirkdev98 merged 1 commit intocompasjs:mainfrom
MrBemd:fix-s3-cleanup
May 5, 2026
Merged

fix(store): flush file deletion batches while iterating in jobFileCleanup#4058
dirkdev98 merged 1 commit intocompasjs:mainfrom
MrBemd:fix-s3-cleanup

Conversation

@MrBemd
Copy link
Copy Markdown
Contributor

@MrBemd MrBemd commented May 5, 2026

Additionally, flush DeleteObjects batches while streaming, not after.

Fixes #4057.

…heck

Additionally, flush DeleteObjects batches while streaming, not after.
@dirkdev98 dirkdev98 changed the title fix(store): use Set for fileSyncDeletedWithObjectStorage membership check fix(store): flush file deletion batches while iterating in jobFileCleanup May 5, 2026
Copy link
Copy Markdown
Member

@dirkdev98 dirkdev98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dirkdev98 dirkdev98 merged commit e307896 into compasjs:main May 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@compas/store: fileSyncDeletedWithObjectStorage does not scale — O(n·m) lookup and unbounded delete buffer

2 participants