Skip to content

[Stack 2/25] CI: run server and E2E tests on PRs targeting jc/** branches#2458

Merged
jucor merged 1 commit intoedgefrom
jc/ci-stack-coverage
Mar 24, 2026
Merged

[Stack 2/25] CI: run server and E2E tests on PRs targeting jc/** branches#2458
jucor merged 1 commit intoedgefrom
jc/ci-stack-coverage

Conversation

@jucor
Copy link
Copy Markdown
Collaborator

@jucor jucor commented Mar 23, 2026

Summary

Next in stack: #2418 (Clojure comparison test consolidation and cleanup)

  • Add jc/** to pull_request.branches in jest-server-test.yml and cypress-tests.yml
  • Stacked PRs target jc/* branches, not edge/stable, so server integration tests and Cypress E2E tests were not running on them
  • python-ci.yml already has this from a prior change; this brings the other two heavy CI workflows in line

Test plan

  • Verify workflow YAML is valid
  • Confirm server and E2E tests trigger on next stack PR push

Generated with Claude Code

Stacked PRs target jc/* branches, not edge/stable, so server
integration tests and Cypress E2E tests were not running on them.
Add jc/** to pull_request.branches so stack PRs get full CI
coverage (python-ci.yml already has this from a prior change).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jucor jucor changed the title CI: run server and E2E tests on PRs targeting jc/** branches [Stack 2/25] CI: run server and E2E tests on PRs targeting jc/** branches Mar 23, 2026
@jucor jucor requested a review from Copilot March 23, 2026 16:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI workflow triggers so server integration (Jest) and Cypress E2E workflows also run for pull requests whose base branch matches jc/**, aligning with the stacked-PR workflow described in the PR.

Changes:

  • Expand pull_request.branches filters in Jest server integration workflow to include jc/**
  • Expand pull_request.branches filters in Cypress E2E workflow to include jc/**

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/jest-server-test.yml Adds jc/** to PR base-branch filters so server integration tests run on stacked PRs
.github/workflows/cypress-tests.yml Adds jc/** to PR base-branch filters so Cypress E2E tests run on stacked PRs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jucor
Copy link
Copy Markdown
Collaborator Author

jucor commented Mar 24, 2026

@ballPointPenguin This one FYI, which I'll merge now: it just makes sure all the PRs in m stack are getting CI-ed properly.

@jucor jucor merged commit 113bb82 into edge Mar 24, 2026
11 checks passed
@jucor jucor deleted the jc/ci-stack-coverage branch March 24, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants