Build a DisassemblyLoader for corerun#4
Merged
Conversation
hez2010
force-pushed
the
main
branch
3 times, most recently
from
c090e24 to
18b8d07
Compare
mattgodbolt
approved these changes
Aug 22, 2023
Member
mattgodbolt
left a comment
mattgodbolt
left a comment
There was a problem hiding this comment.
Gonna trust you on this...
mattgodbolt
pushed a commit
to compiler-explorer/compiler-explorer
that referenced
this pull request
Aug 23, 2023
Depends on compiler-explorer/dotnet-builder#4 - Use corerun instead of crossgen2 to do disassemble - This can skip emitting actual executable by crossgen2 and speed up the compilation - Filter disasm to only show disasm for user code We need to rebuild images for old compilers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This DisassemblyLoader will be used for loading all methods in an assembly, so we can view disassembly code produced by corerun instead of crossgen2.