Fix bounds assertion in GetBoxIndex; refactor SolveDirectionThomas; fix license header#19
Merged
salva24 merged 8 commits intocompiler-research:masterfrom Mar 26, 2026
Conversation
…tionThomas and used .at() for bound safety purposes
salva24
requested changes
Mar 22, 2026
…thm header file for test validation execution purposes
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
salva24
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses three issues identified during a code review of the diffusion solver and utility files.
Commit 1: Added bounds assertion to
GetBoxIndex(diffusion_thomas_algorithm.cc/h);Commit 2: Refactor- Replaced lambda dispatch with
std::arraylookup inSolveDirectionThomas(diffusion_thomas_algorithm.cc);.at()throwsstd::out_of_rangeon an invalid direction value instead of silently falling through to the z-direction branchCommit 3: Fixed license header in
utils_aux.cc;Added test file
test/test-diffusion.ccto cover changes made for GetBoxIndex;