[test] instantiating template multiple times with same types #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| EXPECT_EQ(Decls.size(), 1); | ||
|
|
||
| std::vector<Cpp::TCppFunction_t> candidates; | ||
| for (auto i : Decls) |
Contributor
There was a problem hiding this comment.
warning: 'auto i' can be declared as 'auto *i' [llvm-qualified-auto]
Suggested change
| for (auto i : Decls) | |
| for (auto *i : Decls) |
|
|
||
| std::vector<Cpp::TCppFunction_t> candidates; | ||
| for (auto i : Decls) | ||
| candidates.push_back(i); |
Contributor
There was a problem hiding this comment.
warning: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation]
unittests/CppInterOp/FunctionReflectionTest.cpp:986:
- for (auto i : Decls)
+ candidates.reserve(Decls.size());
+ for (auto i : Decls)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
=======================================
Coverage 79.04% 79.04%
=======================================
Files 9 9
Lines 3879 3879
=======================================
Hits 3066 3066
Misses 813 813 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
vgvassilev
approved these changes
Nov 26, 2025
Contributor
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
Modulo clang-tidy, lgtm!
Vipul-Cariappa
force-pushed
the
test/multi-instantiation
branch
from
bf67337 to
45027c6
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Vipul-Cariappa
merged commit 5534f38
into
compiler-research:main
35 of 36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.