Skip to content

Fix check-xeus-cpp command #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2025
Merged

Fix check-xeus-cpp command #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7deec76
Fix make check_xeus_cpp command
anutosh491 Nov 7, 2025
c8483bb
fix spacing
anutosh491 Nov 7, 2025
b9258b0
fix typo
anutosh491 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/deploy-github-page.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,19 +56,19 @@ jobs:
echo "PREFIX=$PREFIX" >> $GITHUB_ENV
export SYSROOT_PATH=$BUILD_PREFIX/opt/emsdk/upstream/emscripten/cache/sysroot

micromamba create -n node-env -c conda-forge nodejs=22
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"

emcmake cmake \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=$PREFIX \
-DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON \
-DCMAKE_FIND_ROOT_PATH=$PREFIX \
-DSYSROOT_PATH=$SYSROOT_PATH \
-DCMAKE_COMPILE_WARNING_AS_ERROR=ON \
-DCMAKE_COMPILE_WARNING_AS_ERROR=ON \
..

micromamba create -n node-env -c conda-forge nodejs=22
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"

make check-xeus-cpp
emmake make check-xeus-cpp -j ${{ env.ncpus }}
emmake make -j ${{ env.ncpus }} install

- name: Test Emscripten xeus-cpp in browser
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
cd ./chrome/opt/google/chrome/
export PATH="$PWD:$PATH"
cd -

# Install Firefox
wget https://ftp.mozilla.org/pub/firefox/releases/138.0.1/linux-x86_64/en-GB/firefox-138.0.1.tar.xz
tar -xJf firefox-138.0.1.tar.xz
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,19 +228,19 @@ jobs:
echo "PREFIX=$PREFIX" >> $GITHUB_ENV
export SYSROOT_PATH=$BUILD_PREFIX/opt/emsdk/upstream/emscripten/cache/sysroot

micromamba create -n node-env -c conda-forge nodejs=22
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"

emcmake cmake \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=$PREFIX \
-DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON \
-DCMAKE_FIND_ROOT_PATH=$PREFIX \
-DSYSROOT_PATH=$SYSROOT_PATH \
-DCMAKE_COMPILE_WARNING_AS_ERROR=ON \
-DCMAKE_COMPILE_WARNING_AS_ERROR=ON \
..

micromamba create -n node-env -c conda-forge nodejs=22
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"

make check-xeus-cpp
emmake make check-xeus-cpp -j ${{ env.ncpus }}
emmake make -j ${{ env.ncpus }} install

- name: Test Emscripten xeus-cpp in browser
Expand Down Expand Up @@ -300,7 +300,7 @@ jobs:
cd ./chrome/opt/google/chrome/
export PATH="$PWD:$PATH"
cd -

# Install Firefox
wget https://ftp.mozilla.org/pub/firefox/releases/138.0.1/linux-x86_64/en-GB/firefox-138.0.1.tar.xz
tar -xJf firefox-138.0.1.tar.xz
Expand Down
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ export BUILD_PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-cpp-wasm-build
export PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-cpp-wasm-host
export SYSROOT_PATH=$BUILD_PREFIX/opt/emsdk/upstream/emscripten/cache/sysroot

micromamba create -n node-env -c conda-forge nodejs=22
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"

emcmake cmake \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=$PREFIX \
Expand All @@ -92,10 +95,7 @@ emcmake cmake \
-DSYSROOT_PATH=$SYSROOT_PATH \
..

micromamba create -n node-env -c conda-forge nodejs=22
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"

make check-xeus-cpp
emmake make check-xeus-cpp
emmake make install
```

Expand Down
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ export BUILD_PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-cpp-wasm-build
export PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-cpp-wasm-host
export SYSROOT_PATH=$BUILD_PREFIX/opt/emsdk/upstream/emscripten/cache/sysroot

micromamba create -n node-env -c conda-forge nodejs=22
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"

emcmake cmake \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=$PREFIX \
Expand All @@ -107,10 +110,7 @@ emcmake cmake \
-DSYSROOT_PATH=$SYSROOT_PATH \
..

micromamba create -n node-env -c conda-forge nodejs=22
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"

make check-xeus-cpp
emmake make check-xeus-cpp
emmake make install
```

Expand Down
8 changes: 4 additions & 4 deletions docs/source/InstallationAndUsage.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ You are now in a position to build the xeus-cpp kernel. You build and test it in
export PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-cpp-wasm-host
export SYSROOT_PATH=$BUILD_PREFIX/opt/emsdk/upstream/emscripten/cache/sysroot

micromamba create -n node-env -c conda-forge nodejs=22
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"

emcmake cmake \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=$PREFIX \
Expand All @@ -87,10 +90,7 @@ You are now in a position to build the xeus-cpp kernel. You build and test it in
-DSYSROOT_PATH=$SYSROOT_PATH \
..

micromamba create -n node-env -c conda-forge nodejs=22
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"

make check-xeus-cpp
emmake make check-xeus-cpp
emmake make install

It is possible to run the Emscripten tests in a headless browser. We will run our tests in a fresh installed browser. Installing the browsers, and running the tests within the installed browsers will be platform dependent. To do this for Chrome and Firefox on MacOS execute the following
Expand Down