Chore: passing Netlify build#298
Merged
Merged
Conversation
takes precedence over the UI config https://docs.netlify.com/build/configure-builds/file-based-configuration/
as a part of touching these Markdown files, VS Code also fixed some formatting
✅ Deploy Preview for compilerla ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was
linked to
issues
Apr 8, 2026
jgravois
requested changes
Apr 8, 2026
Member
jgravois
left a comment
jgravois
left a comment
There was a problem hiding this comment.
this is already looking mighty sharp! 😎
| "redhat.vscode-xml", | ||
| "Shopify.theme-check-vscode" | ||
| "Shopify.theme-check-vscode", | ||
| "tombi-toml.tombi" |
Member
There was a problem hiding this comment.
seems like overkill to install this extension for one .toml file, but i don't feel strongly about that.
| const now = DateTime.now(); | ||
|
|
||
| const job = {% include job-json.html job=page %}; | ||
| const job = {% include "job-json.html" job=page %}; |
Member
There was a problem hiding this comment.
Suggested change
| const job = {% include "job-json.html" job=page %}; | |
| const job = {% include "job-json.html" job:page %}; |
| <figure> | ||
| <img src="/assets/blog/may2023-retreat.jpg" alt="Photograph of the Compiler team on the 6th Street Bridge in Downtown Los Angeles during their May 2023 Retreat." /> | ||
| <figcaption> {{ "The Compiler team on the 6th Street Bridge in Downtown Los Angeles during their May 2023 Retreat. Photograph by [Lex Ryan](https://www.lexryan.co/)" | markdownify }}</figcaption> | ||
| <figcaption> "The Compiler team on the 6th Street Bridge in Downtown Los Angeles during their May 2023 Retreat. Photograph by <a href="https://lexryan.co/">Lex Ryan</a></figcaption> |
Member
There was a problem hiding this comment.
we could do this with 11ty too, but since its already HTML, i think the change you're suggesting here is ideal.
| <section class="bg-w-100 bg-white"> | ||
| <div class="row"> | ||
| {% include ready-to-work.html h3-class="text-dark" %} | ||
| {% include "ready-to-work.html" h3-class="text-dark" %} |
Member
There was a problem hiding this comment.
Suggested change
| {% include "ready-to-work.html" h3-class="text-dark" %} | |
| {% include "ready-to-work.html", h3-class:"text-dark" %} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #291 and closes #290