feat(runtime): enable current_thread_id on nightly#548
Merged
Berrysoft merged 1 commit intocompio-rs:masterfrom Nov 29, 2025
Merged
feat(runtime): enable current_thread_id on nightly#548Berrysoft merged 1 commit intocompio-rs:masterfrom
Berrysoft merged 1 commit intocompio-rs:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the use of Rust's nightly std::thread::current_id() API as a performance optimization for thread ID retrieval in the runtime. When the current_thread_id feature is enabled on nightly Rust, the code uses the standard library's optimized implementation instead of a thread-local storage fallback.
- Adds
current_thread_idfeature flag to enable nightlystd::thread::current_id()API - Refactors
SendWrapperto conditionally use either the nightly API or thread-local fallback - Includes the new feature in the
nightlymeta-feature for convenience
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| compio/Cargo.toml | Adds current_thread_id feature flag and includes it in the nightly meta-feature |
| compio-runtime/Cargo.toml | Defines the current_thread_id feature flag and includes it in nightly |
| compio-runtime/src/lib.rs | Adds feature gate to enable the nightly current_thread_id Rust feature |
| compio-runtime/src/runtime/send_wrapper.rs | Refactors thread ID retrieval to use std::thread::current_id() when feature is enabled, with fallback to thread-local implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are equvalent on major targets.