refactor(driver): shared fd#661
Merged
George-Miao merged 1 commit intocompio-rs:masterfrom Feb 5, 2026
Merged
Conversation
George-Miao
added
package: driver
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the SharedFd implementation in the driver module to improve code maintainability by extracting common logic into a helper method.
Changes:
- Introduced
into_innerhelper method to extract the innerShared<Inner<T>>fromSharedFd<T> - Simplified
try_unwrapto use the newinto_innerhelper - Refactored
takemethod to useinto_innerand eliminate the unsafetry_unwrap_innerhelper
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Berrysoft
reviewed
Feb 5, 2026
Member
Berrysoft
left a comment
Berrysoft
left a comment
There was a problem hiding this comment.
LGTM. There's similar code in compio-quic, for EndpointRef. Could you also refactor for it?
Member
Author
Sure. Will open another PR for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.