Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Endpoint implementation in the QUIC module to align with the safer pattern established in SharedFd. The changes eliminate potentially unsafe code and improve code maintainability by following established conventions.
Changes:
- Replaced the unsafe
try_unwrap_innermethod with a saferinto_innermethod that properly consumesself - Refactored the
shutdownmethod's unwrap logic to follow the pattern used inSharedFd::take()fromcompio-driver/src/fd.rs - Added necessary imports (
poll_fnandptr) to support the refactored implementation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
George-Miao
added
refactor
George-Miao
force-pushed
the
refactor/quic/endpoint
branch
from
a154ea0 to
2f93451
Compare
George-Miao
force-pushed
the
refactor/quic/endpoint
branch
from
2f93451 to
1a77800
Compare
Berrysoft
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.