fix(runtime): remove generic for ext waker#839
Merged
George-Miao merged 1 commit intocompio-rs:masterfrom Apr 6, 2026
Merged
Conversation
Berrysoft
previously approved these changes
Apr 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the runtime’s “ext waker” plumbing by removing the generic ExtData abstraction and standardizing waker extension data handling around the crate’s Ext type.
Changes:
- Removed the
ExtDatatrait and updatedExtWaker/OwnedExtWakerto carryExtdirectly (non-generic vtables and helpers). - Updated waker helper APIs (
with_ext,get_waker,get_ext) to be non-generic and adjusted call sites accordingly. - Refactored
future::Extto provide an inherentto_owned()method (instead of implementingExtData).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
compio-runtime/src/waker/ext.rs |
Removes generic ext-data handling and makes ext-waker helpers operate on Ext directly. |
compio-runtime/src/future/future.rs |
Updates context helpers to use the new non-generic get_ext/get_waker APIs. |
compio-runtime/src/future/combinator/mod.rs |
Replaces ExtData impl with an inherent Ext::to_owned() used by the waker layer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
George-Miao
force-pushed
the
fix/runtime/ext-waker
branch
from
9ef9524 to
897b6ae
Compare
Member
|
Do you want to handle the check failure here, or in the future? |
Member
Author
|
@Berrysoft Let's do in a separate PR. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.