Skip to content

feat(driver): add more flags to Extra#858

Merged
George-Miao merged 1 commit intocompio-rs:masterfrom
George-Miao:feat/driver/more-flags
Apr 13, 2026
Merged

feat(driver): add more flags to Extra#858
George-Miao merged 1 commit intocompio-rs:masterfrom
George-Miao:feat/driver/more-flags

Conversation

@George-Miao
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 12, 2026 17:45
@George-Miao George-Miao self-assigned this Apr 12, 2026
@George-Miao George-Miao added enhancement New feature or request package: driver Related to compio-driver labels Apr 12, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds additional io_uring-specific capabilities to compio-driver::Extra (SQE flags + CQE helpers) and wires those extras into SQE creation so operations can be configured more flexibly at submission time.

Changes:

  • Extend io_uring Extra to track SQE flags (link/hardlink/drain) separately from CQE flags and expose new setters/getters.
  • Apply Extra to OpEntry during SQE creation and refactor io_uring push path to use a unified create_entry::<FALLBACK>() helper.
  • Adjust Extra::get_personality API to be io_uring-only via io::Result, and update the personality test accordingly.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
compio-driver/tests/personality.rs Updates personality assertions to the new io::Result-based API.
compio-driver/src/sys/iour/mod.rs Adds OpEntry::with_extra to apply Extra settings to SQEs and refactors the push loop to use the new entry-creation helper.
compio-driver/src/sys/iour/extra.rs Splits SQE vs CQE flags, adds SQE flag setters, and adds notif/notification support.
compio-driver/src/sys/extra.rs Introduces an iour_only! macro to generate io_uring-only getters/setters and expands the public Extra API surface.
compio-driver/src/key.rs Adds RawOp::create_entry::<FALLBACK>() helper used by the io_uring driver push path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread compio-driver/src/key.rs Outdated
Comment thread compio-driver/src/sys/iour/mod.rs
Comment thread compio-driver/src/sys/extra.rs
Comment thread compio-driver/src/sys/extra.rs Outdated
Comment thread compio-driver/src/sys/extra.rs
Comment thread compio-driver/src/sys/extra.rs Outdated
Comment thread compio-driver/src/sys/iour/mod.rs
Comment thread compio-driver/src/sys/extra.rs
@George-Miao George-Miao force-pushed the feat/driver/more-flags branch from 9c1e19d to 399dd16 Compare April 12, 2026 18:03
@George-Miao George-Miao force-pushed the feat/driver/more-flags branch from 399dd16 to 3955cb8 Compare April 12, 2026 18:06
@George-Miao George-Miao requested a review from Berrysoft April 13, 2026 00:58
@George-Miao George-Miao added this pull request to the merge queue Apr 13, 2026
Merged via the queue into compio-rs:master with commit fb25ee9 Apr 13, 2026
68 checks passed
@George-Miao George-Miao deleted the feat/driver/more-flags branch April 13, 2026 01:47
@github-actions github-actions bot mentioned this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request package: driver Related to compio-driver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants