feat(driver): add more flags to Extra#858
Merged
George-Miao merged 1 commit intocompio-rs:masterfrom Apr 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional io_uring-specific capabilities to compio-driver::Extra (SQE flags + CQE helpers) and wires those extras into SQE creation so operations can be configured more flexibly at submission time.
Changes:
- Extend io_uring
Extrato track SQE flags (link/hardlink/drain) separately from CQE flags and expose new setters/getters. - Apply
ExtratoOpEntryduring SQE creation and refactor io_uring push path to use a unifiedcreate_entry::<FALLBACK>()helper. - Adjust
Extra::get_personalityAPI to be io_uring-only viaio::Result, and update the personality test accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| compio-driver/tests/personality.rs | Updates personality assertions to the new io::Result-based API. |
| compio-driver/src/sys/iour/mod.rs | Adds OpEntry::with_extra to apply Extra settings to SQEs and refactors the push loop to use the new entry-creation helper. |
| compio-driver/src/sys/iour/extra.rs | Splits SQE vs CQE flags, adds SQE flag setters, and adds notif/notification support. |
| compio-driver/src/sys/extra.rs | Introduces an iour_only! macro to generate io_uring-only getters/setters and expands the public Extra API surface. |
| compio-driver/src/key.rs | Adds RawOp::create_entry::<FALLBACK>() helper used by the io_uring driver push path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9c1e19d to
399dd16
Compare
399dd16 to
3955cb8
Compare
Berrysoft
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.