feat(io): make SyncStream splittable#862
Merged
Berrysoft merged 3 commits intocompio-rs:masterfrom Apr 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the compat::SyncStream adapter to support splitting into independent read/write halves by implementing the crate’s Splittable trait, while refactoring the internal buffering into dedicated read/write buffer helpers.
Changes:
- Refactor
SyncStreambuffering intoSyncReadBuf/SyncWriteBufand addSyncStreamReadHalf/SyncStreamWriteHalf. - Implement
SplittableforSyncStream<S>(whenS: Splittable) to enable.split(). - Update
AsyncReadStream/AsyncWriteStreamto reference the newDEFAULT_MAX_BUFFERlocation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| compio-io/src/compat/sync_stream.rs | Refactors buffering and adds split read/write halves + Splittable impl for SyncStream. |
| compio-io/src/compat/async_stream.rs | Switches to super::DEFAULT_MAX_BUFFER after moving the constant out of SyncStream’s impl. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.