Merged
Conversation
George-Miao
force-pushed
the
refactor/use-rustix
branch
from
54669c6 to
e003acc
Compare
Berrysoft
reviewed
Apr 17, 2026
Member
Berrysoft
left a comment
Berrysoft
left a comment
There was a problem hiding this comment.
It's a bit massive to expose rustix types in the constructors, e.g., Recv::new. But it's up to you.
George-Miao
force-pushed
the
refactor/use-rustix
branch
from
e003acc to
c85bec7
Compare
George-Miao
force-pushed
the
refactor/use-rustix
branch
from
c85bec7 to
0d98402
Compare
Member
Author
Just |
George-Miao
force-pushed
the
refactor/use-rustix
branch
6 times, most recently
from
f2cce67 to
2006fc1
Compare
Berrysoft
reviewed
Apr 17, 2026
George-Miao
force-pushed
the
refactor/use-rustix
branch
6 times, most recently
from
7652438 to
4e1dc0d
Compare
Member
|
Tests are failing on macOS. |
Berrysoft
requested changes
Apr 17, 2026
George-Miao
force-pushed
the
refactor/use-rustix
branch
2 times, most recently
from
101ac79 to
a41109f
Compare
George-Miao
force-pushed
the
refactor/use-rustix
branch
from
a41109f to
a0a7568
Compare
Berrysoft
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Haven't refactored aio yet, will do that in a separate PR with nix.Seems like I have to do that in this PR then