refactor(io): optimize waker array#878
Merged
George-Miao merged 2 commits intocompio-rs:masterfrom Apr 18, 2026
Merged
Conversation
Berrysoft
added
package: io
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors compio-io’s futures-compat AsyncStream waker aggregation to reduce per-poll allocations by introducing a lightweight “array of wakers” wrapper and using it during internal polling.
Changes:
- Add
compat::waker_arraywithWakerArrayRef(customRawWakerimplementation). - Update
compat::AsyncStreaminternals to build a combined waker from stored read/write-related wakers without allocating anArcper poll. - Wire the new module into
compat(mod waker_array;).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| compio-io/src/compat/waker_array.rs | Introduces WakerArrayRef and an owned Wake implementation used when cloned. |
| compio-io/src/compat/async_stream.rs | Switches internal polling to use WakerArrayRef instead of allocating an Arc-backed Wake. |
| compio-io/src/compat/mod.rs | Adds the new waker_array module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
George-Miao
reviewed
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #865
The
compio-wsone will be removed by #875