feat(buf): add ensure_init for convenience#884
Merged
George-Miao merged 5 commits intocompio-rs:masterfrom Apr 21, 2026
Merged
Conversation
Berrysoft
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a convenience IoBufMut::ensure_init() helper (inspired by BorrowedCursor::ensure_init) and refactors several call sites to use it, removing repeated MaybeUninit-to-[u8] initialization patterns.
Changes:
- Add
IoBufMut::ensure_init()default method to zero-initialize and return a&mut [u8]. - Update TLS read path and Windows stdio fallback reads to use
ensure_init()instead of manualMaybeUninithandling. - Simplify QUIC
read_to_endbuffer initialization/copying logic (removing an unsafe slice conversion).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| compio-buf/src/io_buf.rs | Introduces IoBufMut::ensure_init() default method. |
| compio-tls/src/stream.rs | Replaces manual init + unsafe cast with ensure_init() in read_futures. |
| compio-quic/src/recv_stream.rs | Uses slice(..len) + ensure_init(); simplifies chunk copy. |
| compio-io/src/ancillary/mod.rs | Uses ensure_init() before constructing ancillary message iterator. |
| compio-fs/src/stdio/windows.rs | Uses ensure_init() in the non-read_buf Windows stdio read path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by
BorrowedCursor::ensure_init.