fix(cyper): handle IPv6 address in HTTP and HTTP/3 connectors#51
Merged
Berrysoft merged 2 commits intocompio-rs:masterfrom Mar 12, 2026
Merged
fix(cyper): handle IPv6 address in HTTP and HTTP/3 connectors#51Berrysoft merged 2 commits intocompio-rs:masterfrom
Berrysoft merged 2 commits intocompio-rs:masterfrom
Conversation
`Uri::host()` returns IPv6 addresses with brackets (e.g. `[::1]`) per RFC 3986. These brackets caused TCP connection and TLS handshake failures because neither address parsing nor SNI accept bracketed literals. Strip the brackets immediately after extracting the host in both the HTTP/1.1+2 connector (`stream.rs`) and the HTTP/3 connector (`http3.rs`).
Berrysoft
reviewed
Mar 12, 2026
Berrysoft
changed the title
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uri::host() returns IPv6 addresses with brackets (e.g. [::1]) per RFC 3986. When connecting to an IPv6 literal like https://[::1]:8443/, the bracketed host string is passed to both TCP address resolution and TLS SNI, causing connection failures as the address can't be parsed as an Ipv6Addr and falls through to a DNS lookup that fails.
http3.rs already stripped brackets for the TLS server name but not for address resolution. stream.rs didn't strip them at all.
This PR strips the brackets immediately after extracting the host in both connectors.