additional attributes only allow boolean #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthrilly
requested changes
Nov 10, 2020
Member
jthrilly
left a comment
jthrilly
left a comment
There was a problem hiding this comment.
Looks good to me! Just the one small change to the wording and I think its good to merge.
jthrilly
approved these changes
Nov 10, 2020
Member
jthrilly
left a comment
jthrilly
left a comment
There was a problem hiding this comment.
I fixed a typo, so please update the ref in the NC PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only allows boolean additional attributes. Updates migration to remove any non-boolean additional attributes.