Skip to content

fix: support local environment cookie configuration#289

Merged
gusfcarvalho merged 4 commits intomainfrom
gc-fix-environment-configuration
Dec 10, 2025
Merged

fix: support local environment cookie configuration#289
gusfcarvalho merged 4 commits intomainfrom
gc-fix-environment-configuration

Conversation

@gusfcarvalho
Copy link
Contributor

Allows for CCF to work on browsers like Safari on development environment.

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copilot AI review requested due to automatic review settings December 10, 2025 10:00
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds environment-based cookie configuration to support local development with browsers like Safari that have stricter requirements for secure cookies. The changes introduce an Environment configuration field that defaults to "production" and adjusts cookie security settings (Secure flag and SameSite mode) based on whether the environment is set to "local", "dev", or "development".

  • Adds Environment field to the Config struct with a default value of "production"
  • Modifies cookie configuration in the authentication handler to set less restrictive security settings for development environments
  • Binds the new CCF_ENVIRONMENT environment variable

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
internal/config/config.go Adds Environment field to Config struct and initializes it from environment variable with "production" default
internal/api/handler/auth/auth.go Implements environment-based cookie configuration, setting Secure=false and SameSite=Lax for dev environments
cmd/root.go Binds the new environment environment variable to viper configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
@gusfcarvalho gusfcarvalho merged commit 08d52cb into main Dec 10, 2025
4 checks passed
@gusfcarvalho gusfcarvalho deleted the gc-fix-environment-configuration branch December 10, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants