fix: support local environment cookie configuration#289
Merged
gusfcarvalho merged 4 commits intomainfrom Dec 10, 2025
Merged
Conversation
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds environment-based cookie configuration to support local development with browsers like Safari that have stricter requirements for secure cookies. The changes introduce an Environment configuration field that defaults to "production" and adjusts cookie security settings (Secure flag and SameSite mode) based on whether the environment is set to "local", "dev", or "development".
- Adds
Environmentfield to theConfigstruct with a default value of "production" - Modifies cookie configuration in the authentication handler to set less restrictive security settings for development environments
- Binds the new
CCF_ENVIRONMENTenvironment variable
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
internal/config/config.go |
Adds Environment field to Config struct and initializes it from environment variable with "production" default |
internal/api/handler/auth/auth.go |
Implements environment-based cookie configuration, setting Secure=false and SameSite=Lax for dev environments |
cmd/root.go |
Binds the new environment environment variable to viper configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for CCF to work on browsers like Safari on development environment.