Merged
Conversation
…ation page Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive OIDC (OpenID Connect) authentication support to the Compliance Framework API, enabling SSO login through providers like Google and GitHub alongside the existing password-based authentication.
Key Changes
- Added OIDC configuration system with support for multiple authentication providers (Google, GitHub, and generic OIDC)
- Implemented Just-In-Time (JIT) user provisioning with group-based authorization
- Restructured user management API routes to
/admin/userswith new admin group enforcement middleware - Modified User model to support multiple authentication methods and remove password requirement for OIDC users
Reviewed changes
Copilot reviewed 16 out of 19 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| oidc.yaml | Configuration template for OIDC providers with example Google and GitHub setups |
| internal/config/oidc.go | OIDC configuration loader with environment variable expansion support |
| internal/service/relational/oidc.go | Database model for linking users to external OIDC providers |
| internal/service/relational/ccf_internal.go | Modified User model to support OIDC authentication method |
| internal/service/oidc/service.go | Core OIDC service implementing provider initialization, OAuth flows, and user info retrieval |
| internal/api/handler/auth/oidc.go | HTTP handlers for OIDC login flow including provider listing and callback handling |
| internal/api/middleware/admin.go | New middleware enforcing admin group requirements for OIDC users |
| internal/api/handler/users.go | Enhanced user handler with OIDC provider information and split routes |
| internal/api/handler/api.go | Route registration splitting admin and self-service user endpoints |
| go.mod / go.sum | Added dependencies for coreos/go-oidc and golang.org/x/oauth2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix: integration test failures Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 71 out of 72 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.