fix: same site cookies for sso/ normal login #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes SameSite cookie attributes for authentication flows to properly support OAuth2/OIDC-based SSO while maintaining stronger security for direct login.
Key Changes:
- SSO OAuth state cookie now uses
SameSiteLaxModeuniformly (was conditionally Strict in production) - SSO auth token cookie now uses
SameSiteLaxModeuniformly (was conditionally Strict in production) - Normal login auth token cookie now uses
SameSiteStrictModeuniformly (was conditionally Lax in development)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
internal/api/handler/auth/sso.go |
Updates OAuth state cookie and SSO auth token cookie to use SameSiteLaxMode consistently across environments, with explanatory comment about OAuth2/OIDC flow requirements |
internal/api/handler/auth/auth.go |
Updates normal login auth token cookie to use SameSiteStrictMode consistently across environments for enhanced security |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.