fix: overdue bugs from copilot

[gusfcarvalho]

No description provided.

[Copilot]

Pull request overview

This pull request fixes several bugs related to evidence creation timing and validation in workflow and step execution status updates. The main issue being addressed is that evidence was being created before status updates, which could lead to inconsistencies. The PR moves evidence creation to occur after status updates and relaxes validation to handle both pre- and post-transition states.

Changes:

• Moved evidence creation from before to after status updates in both workflow and step execution services
• Added early returns when status update is a no-op (status already matches target)
• Fixed a typo where "complete" should have been "completed" in evidence validation
• Updated validation to allow evidence creation for both pending/in_progress states (started) and in_progress/completed states (completed)
• Fixed step execution service to load due_date field when needed for setDueDateIfNeeded logic
• Updated tests to reflect that evidence now captures the post-transition status

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
internal/workflow/evidence.go	Relaxed validation to allow evidence creation in both pre- and post-transition states; fixed typo changing "complete" to "completed"
internal/service/relational/workflows/workflow_execution_service.go	Moved evidence creation to after status update; added early return for no-op updates
internal/service/relational/workflows/step_execution_service.go	Moved evidence creation to after status update; added early return for no-op updates; added due_date to Select calls for setDueDateIfNeeded
internal/workflow/evidence_test.go	Updated test expectations to reflect post-transition status; improved test names and comments for clarity

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.