fix(email): add missing POAM notification email templates#373
Closed
AKAbdulHanif wants to merge 1 commit into
Closed
fix(email): add missing POAM notification email templates#373AKAbdulHanif wants to merge 1 commit into
AKAbdulHanif wants to merge 1 commit into
Conversation
Three workers referenced email templates that did not exist as embedded files, causing the email service to fail at runtime with a template-not- found error: - poam-overdue-notification (PoamOverdueNotificationWorker) - poam-deadline-reminder (PoamDeadlineReminderWorker) - poam-milestone-overdue-reminder (MilestoneOverdueReminderWorker) Added HTML and plain-text variants for all three templates, following the style and variable conventions established by the existing poam-open-digest and risk-* templates. Also added TestTemplateService_Poam* unit tests to the template service test suite so that missing templates are caught at test time rather than at runtime.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three workers referenced email templates that did not exist as embedded files, causing the email service to fail at runtime with a template-not- found error:
Added HTML and plain-text variants for all three templates, following the style and variable conventions established by the existing poam-open-digest and risk-* templates.
Also added TestTemplateService_Poam* unit tests to the template service test suite so that missing templates are caught at test time rather than at runtime.