Upgrade to new APIs in agent and configuration service versions 0.1.1 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to check it's behaving as it used to do before (with a couple of minor fixes too)
strottos
changed the title
| Remarks: StringAddressed("`dpkg-query -W -f='${Package} ${Version}'` is used to collect the installed packages and their versions."), | ||
| }) | ||
|
|
||
| command := `dpkg-query -W -f='${Package} ${Version}\n'` |
| assert.Equal(t, len(packages), len(packageStrings)) | ||
|
|
||
| // Check the correct packages are in the map | ||
| for expectedPkg, expectedVersion := range map[string]string{ |
Contributor
Author
There was a problem hiding this comment.
It's overkill for sure, I got overexcited 😂
harrylincoln-CS
approved these changes
Mar 26, 2025
chris-cmsoft
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reimplemented the complex sed into go as found a few bugs, e.g. previously it was turning "23.2.3" to "3.2.3" which is obviously not what we wanted. I think the logic is now much more straightforward.
Don't 100% guarantee we're doing the right thing every time but I believe it's at least backwards compatible with before. Added a couple of TODO's in the test for real examples of packages that I wasn't certain about.