Merged
Conversation
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the API endpoint name from /api/users/me/digest-subscription to /api/users/me/subscriptions and renames the corresponding TypeScript interface from DigestSubscriptionPreferences to SubscriptionsPreferences. This appears to be a refactoring to use a more general naming convention that better reflects the endpoint's broader scope of handling multiple subscription types (digest, task available, and task daily digest).
Changes:
- Renamed TypeScript interface from
DigestSubscriptionPreferencestoSubscriptionsPreferences - Updated API endpoint from
/api/users/me/digest-subscriptionto/api/users/me/subscriptionsin both GET and PUT requests - Updated all test mocks to use the new endpoint name
- Updated code comments to reflect the new naming ("subscriptions" instead of "digest subscription")
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/views/PreferencesView.vue | Updated interface name, API endpoint URLs, and related comments to use the new "subscriptions" naming convention |
| src/views/tests/PreferencesView.spec.ts | Updated all test mocks to use the new /api/users/me/subscriptions endpoint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.