Skip to content

fix: user search#208

Merged
gusfcarvalho merged 1 commit intomainfrom
gc-fix-user-serach
Mar 20, 2026
Merged

fix: user search#208
gusfcarvalho merged 1 commit intomainfrom
gc-fix-user-serach

Conversation

@gusfcarvalho
Copy link
Contributor

No description provided.

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copilot AI review requested due to automatic review settings March 20, 2026 09:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the useUserSearch composable to hydrate missing users by fetching a single user-by-id endpoint (instead of querying the selectable-users search endpoint) and adjusts the corresponding test mock.

Changes:

  • Add a minimal PublicUserResponse shape and mapping helper (toPublicDisplayUser) for user-by-id hydration.
  • Update loadUsersByIds to call GET /api/users/{id} and cache the hydrated user.
  • Update the loadUsersByIds integration test mock to return {id, name} for the new endpoint.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/composables/workflows/useUserSearch.ts Switch missing-user hydration to /api/users/{id} and map the minimal response into DisplayUser.
src/composables/workflows/tests/useUserSearch.spec.ts Update hydration test mock to parse /api/users/{id} requests and return a minimal {id, name} payload.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gusfcarvalho gusfcarvalho merged commit 6574ba4 into main Mar 20, 2026
6 checks passed
@gusfcarvalho gusfcarvalho deleted the gc-fix-user-serach branch March 20, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants