Merged
Conversation
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the useUserSearch composable to hydrate missing users by fetching a single user-by-id endpoint (instead of querying the selectable-users search endpoint) and adjusts the corresponding test mock.
Changes:
- Add a minimal
PublicUserResponseshape and mapping helper (toPublicDisplayUser) for user-by-id hydration. - Update
loadUsersByIdsto callGET /api/users/{id}and cache the hydrated user. - Update the
loadUsersByIdsintegration test mock to return{id, name}for the new endpoint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/composables/workflows/useUserSearch.ts | Switch missing-user hydration to /api/users/{id} and map the minimal response into DisplayUser. |
| src/composables/workflows/tests/useUserSearch.spec.ts | Update hydration test mock to parse /api/users/{id} requests and return a minimal {id, name} payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.