chore: remove Gemara display content from mock OCI registry#529
Open
sonupreetam wants to merge 2 commits into
Open
chore: remove Gemara display content from mock OCI registry#529sonupreetam wants to merge 2 commits into
sonupreetam wants to merge 2 commits into
Conversation
Contributor
✅ CRAP Load Analysis: PASSSummary
|
1aa8362 to
f3dafcb
Compare
f3dafcb to
5febdb3
Compare
marcusburghardt
requested changes
May 27, 2026
Member
marcusburghardt
left a comment
There was a problem hiding this comment.
Review Summary
Solid cleanup PR — removes ~4,750 lines of mock Gemara content as intended by #477. Two actionable findings:
- CI linter failure (gosec G706): The
//nolint:gosecdirective was dropped when the log message was renamed. Trivial fix. complytime.yamlstill points at localhost mock: Should referencequay.io/complytime/policies-ampel-branch-protectionnow that the mock content is being removed in favor of quay.io releases.
This review was generated by /review-pr (AI-assisted).
sonupreetam
added a commit
that referenced
this pull request
May 28, 2026
- Restore //nolint:gosec directive on renamed log line (gosec G706) - Revert inlined variables in OCI route handlers for readability - Update complytime.yaml to reference quay.io production registry instead of localhost mock Signed-off-by: sonupreetam <spreetam@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
sonupreetam
added a commit
that referenced
this pull request
May 28, 2026
- Restore //nolint:gosec directive on renamed log line (gosec G706) - Revert inlined variables in OCI route handlers for readability - Update complytime.yaml to reference quay.io production registry instead of localhost mock Signed-off-by: sonupreetam <spreetam@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: sonupreetam <spreetam@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
4c64b73 to
27e35c0
Compare
Contributor
Author
|
@marcusburghardt Thank you I have taken care of the feedbacks. |
sonupreetam
added a commit
that referenced
this pull request
May 28, 2026
- Restore //nolint:gosec directive on renamed log line (gosec G706) - Revert inlined variables in OCI route handlers for readability - Update complytime.yaml to reference quay.io production registry instead of localhost mock Signed-off-by: sonupreetam <spreetam@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: sonupreetam <spreetam@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: sonupreetam <spreetam@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
27e35c0 to
dca9529
Compare
Member
|
@sonupreetam , there is a conflict. We need to rebase in order to solve it. |
Remove all Gemara content from mock-oci-registry except the minimal test-branch-protection catalog and policy used by cross-repo integration tests. This includes: - 5 testdata files (ampel-branch-protection-*, cis-fedora-l1-*, sample-complytime) - All inline YAML seeds (nist-800-53-r5, cis-benchmark, osps-b, guidance/nist) - Enrichment endpoint (/v1/enrich) and all enrichment types/mappings The mock registry now serves only policies/test-branch-protection, shrinking main.go from ~670 to ~255 lines (-4750 lines total). The root complytime.yaml is updated to reference the retained policy. Closes #477 Assisted-by: Cursor (claude-opus-4-6) Signed-off-by: sonupreetam <spreetam@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
- Restore //nolint:gosec directive on renamed log line (gosec G706) - Revert inlined variables in OCI route handlers for readability - Update complytime.yaml to reference quay.io production registry instead of localhost mock Signed-off-by: sonupreetam <spreetam@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: sonupreetam <spreetam@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: sonupreetam <spreetam@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
dca9529 to
539b583
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #477
cmd/mock-oci-registry/except the minimaltest-branch-protection-catalog.yamlandtest-branch-protection-policy.yamlused by integration tests/v1/enrich) and all enrichment types/mappings frommain.gointegration_test.shto usepolicies/test-branch-protectioninstead of the removednist-800-53-r5, installing the test provider ascomplyctl-provider-ampelto match the policy's executor IDcomplytime.yamlto reference the retainedtest-branch-protectionpolicyResult:
main.goshrinks from ~670 to ~255 lines. Total -4,750 lines removed.Files deleted (5)
ampel-branch-protection-catalog.yamlampel-branch-protection-policy.yamlcis-fedora-l1-workstation-catalog.yamlcis-fedora-l1-workstation-policy.yamlsample-complytime.yamlFiles retained (2)
test-branch-protection-catalog.yamltest-branch-protection-policy.yamlImpact
make test-integration: Updated — now usespolicies/test-branch-protectionwith the test provider installed ascomplyctl-provider-ampelto match the policy executormake test-cross-repo: Unaffected — already usespolicies/test-branch-protectionmake test-e2e/make test-behavioral: Unaffected — use separate in-process mocksreusable_compliance.yml: Referencespolicies/ampel-branch-protection— needs updating separately to use Quay.io release ortest-branch-protectionSpec workflow exemption
This change was not preceded by an OpenSpec or Speckit spec workflow. Rationale:
Per AGENTS.md, spec workflows are required for non-trivial changes. While the line count is large, the change is mechanical deletion with minimal logic changes. Future cleanups of comparable scope should consider a lightweight OpenSpec proposal to formalize the rationale upfront.
Test plan
go build ./cmd/mock-oci-registry/compiles cleango vet ./cmd/mock-oci-registry/passesmake test-integrationpasses with updated policy and provider namemake test-cross-repopasses (retained content, no changes)