Skip to content

chore: remove gemini review#820

Merged
huiwangredhat merged 1 commit intocomplytime:mainfrom
huiwangredhat:remove_gemini_review
Apr 8, 2026
Merged

chore: remove gemini review#820
huiwangredhat merged 1 commit intocomplytime:mainfrom
huiwangredhat:remove_gemini_review

Conversation

@huiwangredhat
Copy link
Copy Markdown
Contributor

@huiwangredhat huiwangredhat commented Apr 7, 2026

Summary

I received an email about Workflow Configuration Risks. I think it's time to remove the Gemini CLI review workflow. Here I listed two reasons:

  • The Gemini CLI review is no longer meaningful. Because we now use the Claude code, the cursor helps us generate code. The real human review is more important than the Genini review at that stage.
  • An outside collaborator with read-only access can trigger the workflow by
    opening a PR, causing:
    1. GCP Vertex AI API consumption (cost impact via secrets.GCP_SA_KEY)
    2. Secrets are not leaked to the collaborator, but the workflow runs on their behalf and consumes cloud resources.

Signed-off-by: Sophia Wang <huiwang@redhat.com>
@huiwangredhat huiwangredhat marked this pull request as ready for review April 8, 2026 03:06
Copy link
Copy Markdown
Contributor

@AlexXuan233 AlexXuan233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huiwangredhat huiwangredhat merged commit 4c3045f into complytime:main Apr 8, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants