`POSIXTerminal` `deinit` not called.

[zaneenders]

The POSIXTerminal deinit does not seem to be called on Linux or MacOS when closing the demo using ctrl-c. I did some testing by adding fatalError("not called") as the first line of the deinit.

I see you have a note about setting up a SIGWINCH handler would an acceptable fix be adding a SIGINT handler and manually reset termios?

Thanks,
Zane

[zaneenders]

Or maybe this should be handled in the user side by setting up the following?

edit: this won't work as the process terminates before this code is called.

for try await event in renderer.terminal.input {
    switch event {
    case .key(let key) where key.character == "c" && key.modifiers == .ctrl:
        return
    default:
        break
    }
}

[compnerd]

Ah, this is not entirely a bug, it is a missing feature. The ^C is actually a signal - SIGTERM. The idea for that that I have is that we should have an enumeration of signals, and register a signal handler that would allow us to execute the defer block in the main block.

I wanted to also figure out how to get the defer block to execute in an atexit handler.

[compnerd]

Hey @zaneenders I believe that I have a viable implementation for a signal handler mechanism. I'm going to push that into swift-platform-core. Once integrated, I think that it should be straightforward to add the signal handler(s) - I think that we should handle SIGTERM, SIGQUIT, and SIGHUP at the very least. WDYT?

[zaneenders]

I rebased my branch to compnerd/interruption give this a try and it works. Very cool!

There is also ISIG which I used as a hack to get around this in my experimentation.

[compnerd]

I think that ensuring that ISIG is set is likely prudent, we want to read ^C as a signal not a key chord. Feel free to send a PR for that.