[freebsd] fix the freebsd build #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to verify some Linux-specific changes don't break other platforms and found that ds2 doesn't currently build on FreeBSD 14.0. These patches address the issues encountered.
The most noteworthy change is the addition of
file(MAKE_DIRECTORY)calls to theRegsGen2steps. This step was failing on FreeBSD because the directories did not already exist. Not sure why it succeeds on other platforms, but theMAKE_DIRECTORYaddition should be harmless when not needed.Validation
Built on VM running 14.0-RELEASE-p10.
Launched ds2 on FreeBSD in platform mode, verified lldb can connect.