skip annotating classes with only defaulted, deleted, or pure virtual methods#48
Merged
andrurogerz merged 3 commits intocompnerd:mainfrom Apr 28, 2025
Merged
Conversation
andrurogerz
changed the title
compnerd
approved these changes
Apr 28, 2025
Co-authored-by: Saleem Abdulrasool <compnerd@compnerd.org>
compnerd
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make annotating at the class level for vtable export more strict.
Background
b7cb8df introduced exporting at the class level for class definitions with out-of-line virtual methods. However, the check for virtual methods requiring export was not as strict as it could be: defaulted, deleted, and pure virtual methods do not require the vtable to be exported.
Validation