configure: Set cmake arch value to i686 for Windows #1020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream Swift repository sets the value to `i686`. While this is incorrects and CMake expects `X86`, this is used in a few projects so we update the value here to match upstream behavior.
compnerd
approved these changes
Sep 5, 2025
Steelskin
changed the title
mhegazy
approved these changes
Sep 5, 2025
Collaborator
mhegazy
left a comment
mhegazy
left a comment
There was a problem hiding this comment.
thanks for figuring this one out!
Steelskin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream Swift repository sets the value to
i686. While this is incorrect and CMake expectsX86, this is used in a few projects so we update the value here to match upstream behavior.