Packaging: Set productArchitecture
#941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
compnerd
reviewed
Apr 21, 2025
Owner
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Should we not be passing that across the other MSIs as well?
Collaborator
Author
It seems to be only used by that one target but I don't know if msbuild and/or wix also use that property internally. |
Steelskin
force-pushed
the
fabrice/package-build-tools-product-arch
branch
from
ebf5ecd to
d3c7607
Compare
Steelskin
changed the title
productArchitecture in Package jobproductArchitecture
Collaborator
Author
Actually I was wrong, I updated the PR. Here's the new try job: https://github.com/thebrowsercompany/swift-build/actions/runs/14577741095 |
compnerd
reviewed
Apr 21, 2025
Collaborator
Author
compnerd
approved these changes
Apr 21, 2025
Owner
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
The smoke test failed, but the packaging succeeded. I think that this is a good step forward.
Steelskin
pushed a commit
that referenced
this pull request
Apr 28, 2025
This updates the packaging steps following swiftlang/swift-installer-scripts#413 This cherry-picks the following PRs: * GHA: shuffle the Foundation headers #918 * GHA: shuffle more files for Dispatch, Foundation #935 * Create directory before moving items #936 * GHA: adjust the installer build phases #937 * GHA: enable _Builtin_float on android #942 * Installer: Properly include Android platform #944 * Update Android root folder #943 * Packaging: Set productArchitecture #941 * Android: Update Android platform packaging #940
Merged
Steelskin
added a commit
that referenced
this pull request
Apr 29, 2025
This updates the packaging steps following swiftlang/swift-installer-scripts#413 This cherry-picks the following PRs: * GHA: shuffle the Foundation headers #918 * GHA: shuffle more files for Dispatch, Foundation #935 * Create directory before moving items #936 * GHA: adjust the installer build phases #937 * GHA: enable _Builtin_float on android #942 * Installer: Properly include Android platform #944 * Update Android root folder #943 * Packaging: Set productArchitecture #941 * Android: Update Android platform packaging #940 Co-authored-by: Saleem Abdulrasool <abdulras@thebrowser.company>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Windows Arm64 build job.