Update configure-aws-credentials and ccache-action #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Apr 24, 2025
Owner
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
LGTM outside of the minor thing about the action reference.
Collaborator
Author
|
@compnerd feel free to merge when you can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes attempt to address the intermittent failure we are seeing during the sccache initialization.
Switch to use
thebrowsercompany/ccache-actioninstead ofhendrikmuhs/ccache-action.The only difference is updating to a newer version of sccache (
v0.10.0instead ofv0.7.6).The changes between the two are pushed to a PR (Update sccache version to v0.10.0: Update sccache version to v0.10.0 hendrikmuhs/ccache-action#315). Once merged, we can revert back to the upstream release.
Update
configure-aws-credentialsto the latest version.This update uses the
special-characters-workaroundflag that was introduced last year.The flag seems to address the issue we are running into. The action will now check if the AWS secrets have any special characters ("+" or "/" among others), and if so, it will request a new identity.
See details in the original issue: #599, and linked aws-cli issue #2665