fix(router): resolve non-relative spreads via baseUrl

closes #1308

Author: vogloblinsky

src/utils/router-parser.util.ts

@@ -1146,7 +1146,8 @@ export class RouterParserUtil {
 
     /**
      * Resolve a TypeScript path alias (tsconfig compilerOptions.paths) to an absolute file path.
-     * Returns undefined when no alias matches or the tsconfig is unavailable.
+     * Also supports non-relative imports resolved via compilerOptions.baseUrl.
+     * Returns undefined when no mapping matches or the tsconfig is unavailable.
      */
     private resolvePathAlias(moduleSpecifier: string): string | undefined {
         try {
@@ -1155,7 +1156,7 @@ export class RouterParserUtil {
 
             const tsconfig = readConfig(tsconfigPath);
             const compilerOptions = tsconfig?.compilerOptions;
-            if (!compilerOptions?.paths) return undefined;
+            if (!compilerOptions) return undefined;
 
             const baseUrl = compilerOptions.baseUrl
                 ? path.resolve(
@@ -1164,27 +1165,40 @@ export class RouterParserUtil {
                   )
                 : path.dirname(tsconfigPath);
 
-            for (const [pattern, replacements] of Object.entries(
-                compilerOptions.paths as Record<string, string[]>,
-            )) {
-                if (!Array.isArray(replacements) || replacements.length === 0)
-                    continue;
+            if (compilerOptions.paths) {
+                for (const [pattern, replacements] of Object.entries(
+                    compilerOptions.paths as Record<string, string[]>,
+                )) {
+                    if (
+                        !Array.isArray(replacements) ||
+                        replacements.length === 0
+                    )
+                        continue;
 
-                // Convert glob pattern to regex: "@shared/*" → /^@shared\/(.*)$/
-                const regexStr = pattern
-                    .replace(/[-[\]{}()+?.,\\^$|#\s]/g, "\\$&")
-                    .replace(/\*/g, "(.*)");
-                const regex = new RegExp("^" + regexStr + "$");
-                const match = moduleSpecifier.match(regex);
-
-                if (match) {
-                    const resolved = (replacements[0] as string).replace(
-                        /\*/g,
-                        match[1] ?? "",
-                    );
-                    return path.resolve(baseUrl, resolved);
+                    // Convert glob pattern to regex: "@shared/*" → /^@shared\/(.*)$/
+                    const regexStr = pattern
+                        .replace(/[-[\]{}()+?.,\\^$|#\s]/g, "\\$&")
+                        .replace(/\*/g, "(.*)");
+                    const regex = new RegExp("^" + regexStr + "$");
+                    const match = moduleSpecifier.match(regex);
+
+                    if (match) {
+                        const resolved = (replacements[0] as string).replace(
+                            /\*/g,
+                            match[1] ?? "",
+                        );
+                        return path.resolve(baseUrl, resolved);
+                    }
                 }
             }
+
+            const isNonRelative =
+                !moduleSpecifier.startsWith("./") &&
+                !moduleSpecifier.startsWith("../") &&
+                !path.isAbsolute(moduleSpecifier);
+            if (isNonRelative) {
+                return path.resolve(baseUrl, moduleSpecifier);
+            }
         } catch (_e) {
             // silently skip — tsconfig may not be readable at this point
         }

test/fixtures/baseurl-spread/src/app/features/category/custom-category-routing.ts

@@ -0,0 +1,5 @@
+import { Route } from "@angular/router";
+
+export const customCategoryRoutes: Route[] = [
+    { path: "category", component: "CategoryComponent" as any },
+];

test/fixtures/baseurl-spread/src/app/sections/main/main-routing.module.ts

@@ -0,0 +1,4 @@
+import { Routes } from "@angular/router";
+import { customCategoryRoutes } from "features/category/custom-category-routing";
+
+export const routes: Routes = [...customCategoryRoutes];

test/fixtures/baseurl-spread/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "baseUrl": "src/app"
+    }
+}

test/src/utils/router-parser.util.spec.ts

@@ -497,6 +497,10 @@ const routes = [
             __dirname,
             "../../../../../test/fixtures/path-alias-spread",
         );
+        const baseUrlFixtureRoot = path.join(
+            __dirname,
+            "../../../../../test/fixtures/baseurl-spread",
+        );
         const relativeFixtureRoot = path.join(
             __dirname,
             "../../../../../test/fixtures/relative-spread-import",
@@ -607,5 +611,33 @@ export const routes: Routes = [{ path: 'root', children: [...langs.map(lang => (
                 routerParser.scannedFiles = previousScannedFiles;
             }
         });
+
+        it("should resolve spread imports via tsconfig baseUrl in nested routing files (issue #1308)", () => {
+            const previousScannedFiles = routerParser.scannedFiles;
+            try {
+                routerParser.scannedFiles = [];
+                Configuration.mainData.tsconfig = path.join(
+                    baseUrlFixtureRoot,
+                    "tsconfig.json",
+                );
+
+                const project = new Project();
+                const sourceFile = project.addSourceFileAtPath(
+                    path.join(
+                        baseUrlFixtureRoot,
+                        "src/app/sections/main/main-routing.module.ts",
+                    ),
+                );
+                expect(() =>
+                    routerParser.cleanFileSpreads(sourceFile),
+                ).not.to.throw();
+                expect(sourceFile.getText()).not.to.contain(
+                    "...customCategoryRoutes",
+                );
+                expect(sourceFile.getText()).to.contain('path: "category"');
+            } finally {
+                routerParser.scannedFiles = previousScannedFiles;
+            }
+        });
     });
 });