dependency with local sub-components doesn't install fully

[matthewmueller]

The subcomponents won't be installed if you have a dependency that contains additional local components.

[jonathanong]

yeah, locals only works with "local" components, not remote components. i do want this though so you could split up your app into separate repos or something. it's a little more difficult to resolve though as it would require more HTTP requests (unless we download the entire repo) and we have to make sure all the locals are encapsulated.

[TooTallNate]

so you could split up your app into separate repos or something

Exactly :) Is a quick fix possible or is it a good amount of code?

[jonathanong]

yeah i don't think it would be too difficult in my resolver. probably more difficult in the current component. i'll look into it this weekend since i want it too :D

[jonathanong]

aside: how do you guys think we should handle IDs?

we can ID remote components as <user>-<repo>@<version>. the problem is that we don't want conflicts with local component names, so i was thinking path.relative(process.cwd(), <component-folder>), but then i'm not sure how to handle dependencies' locals.

we could also just give them all unique hashes like browserify, but then it's harder to read and debug.

[dominicbarnes]

Using path.relative is a great idea. One thing to consider is what if one of the configured paths happens to look outside process.cwd()? (perhaps that would be a special case?)

[jonathanong]

the problem is that when we copy/symlink stuff, how do we handle paths that start with ../? imo they should be separate repos, and you should be able to symlink them as a dependency in development. so you could have model above process.cwd(), but it will be treated as /dominicbarnes/model/1.2.3/ in the build.

stuff outside process.cwd() doesn't make sense to me, much like how stuff outside main's folder doesn't make sense to me either.

[jonathanong]

hmmm if we do this, the apps need a JS entry point. should we allow users to specify the main as one of the locals? or have it implied as one of the locals if there's only one defined?

[jonathanong]

i'm going to throw if there's more than one local. if there are no scripts, then the component will actually be the local. we can figure out the specs later

[timaschew]

This has beed fixed, it works fine with 1.0.0, I think it was already fixed in rc-5
I think @jonathanong forgot to close this issue ;)