library: add shadow to color picker indicator and opt Spinner as Dialog #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the color mappings to align with Material Design 3. - In `Material3Mapping.kt`, `tertiaryContainer` and `onTertiaryContainer` are now mapped directly to the Material 3 `tertiaryContainer` and `onTertiaryContainer` colors, respectively. - In `SuperSpinner.kt`, the default `containerColor` for `dialogSpinnerColors` is changed to `Color.Transparent`.
wxxsfxyzm
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds visual enhancements to the color picker components and updates the dialog spinner styling. The changes improve the appearance of color selection indicators by adding shadow effects and optimize the Spinner component for use in dialogs.
- Adds shadow/glow effects to color picker and palette selection indicators
- Updates Material3 color mapping to use proper tertiary container colors
- Changes dialog spinner container background to transparent
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| miuix/src/commonMain/kotlin/top/yukonga/miuix/kmp/theme/Material3Mapping.kt | Updates tertiary container color mapping to use proper Material3 tertiary colors instead of primary container |
| miuix/src/commonMain/kotlin/top/yukonga/miuix/kmp/extra/SuperSpinner.kt | Changes dialog spinner default container color from surface variant to transparent |
| miuix/src/commonMain/kotlin/top/yukonga/miuix/kmp/basic/ColorPicker.kt | Replaces simple border with custom shadow rendering using radial gradient for slider indicator |
| miuix/src/commonMain/kotlin/top/yukonga/miuix/kmp/basic/ColorPalette.kt | Replaces simple border with custom shadow rendering using radial gradient for palette indicator |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
miuix/src/commonMain/kotlin/top/yukonga/miuix/kmp/theme/Material3Mapping.kt
Outdated
Show resolved
Hide resolved
…al3Mapping.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.