example: improve wide-screen detection #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wide-screen detection logic is enhanced to better handle various device sizes and orientations. The new logic considers two conditions: - The screen width exceeds a large threshold (`WIDE_SCREEN_THRESHOLD`). - The screen width is above a medium threshold (`MEDIUM_WIDTH_THRESHOLD`) and the aspect ratio is landscape-like. This ensures a two-pane layout is used not only on very wide screens but also on devices like landscape phones or unfolded foldables.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the wide-screen detection logic in the example app to better support various device sizes and orientations, particularly landscape phones and unfolded foldables.
- Introduces a two-tiered detection system: definite wide screens (>840dp) and medium-width landscape devices (>600dp with landscape aspect ratio)
- Adds new constants for medium width threshold and aspect ratio detection
- Replaces single-condition wide-screen detection with a dual-condition OR logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
YuKongA
force-pushed
the
wide-screen-patch
branch
from
b4a5b7e to
b708317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wide-screen detection logic is enhanced to better handle various device sizes and orientations.
The new logic considers two conditions:
WIDE_SCREEN_THRESHOLD).MEDIUM_WIDTH_THRESHOLD) and the aspect ratio is landscape-like.This ensures a two-pane layout is used not only on very wide screens but also on devices like landscape phones or unfolded foldables.
Feel free to review and close this if you don't think it is necessary.