Even more ostree work#340
Merged
Merged
Conversation
This is mainly useful when testing non-delta codepaths. Signed-off-by: Alexander Larsson <alexl@redhat.com>
Signed-off-by: Alexander Larsson <alexl@redhat.com>
There is no need to make this any special, its just an essentially random value. Signed-off-by: Alexander Larsson <alexl@redhat.com>
Signed-off-by: Alexander Larsson <alexl@redhat.com>
Signed-off-by: Alexander Larsson <alexl@redhat.com>
Signed-off-by: Alexander Larsson <alexl@redhat.com>
Signed-off-by: Alexander Larsson <alexl@redhat.com>
Signed-off-by: Alexander Larsson <alexl@redhat.com>
This changes the way we store data offsets to be byte offset / 8, which makes us able to store 32GB of data instead of 4GB, with no change in file size. This is an incompatible change, but I don't think we have any real users yet, so is fine. Also add some more checks to DataRef::new to ensure size and offset are valid. Signed-off-by: Alexander Larsson <alexl@redhat.com>
This was referenced Jul 1, 2026
Merged
cgwalters
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly some cleanups from comments outstanding in previous MRs.
There is one real change, which is the changing of offsets in the commit splitstreams to be divided by 8. I think its fine to do this even though this is a format change. I don't think we're guaranteeing this to be stable yet.