parse: Consume record-size padding in ParseEvent::End#24
Merged
Conversation
cgwalters
force-pushed
the
handle-archive-records
branch
from
0746611 to
f3ca10f
Compare
xref https://github.com/composefs/composefs-rs#290 GNU tar and Python's tarfile both pad archives to a record boundary (default 20×512 = 10,240 bytes) after the two mandatory end-of-archive zero blocks. Previously ParseEvent::End only reported consumed: 2×512, leaving the trailing padding bytes unaccounted for. Normally this doesn't even matter, because callers will only be interested in parsing the stream and discarding the underlying bytes. But composefs wants to do a "splitstream" which preserves those bytes. Assisted-by: OpenCode (claude-sonnet-4-6@default) Signed-off-by: Colin Walters <walters@verbum.org>
The published lockfile for cargo-fuzz pins rustix 0.36, which uses rustc_layout_scalar_valid_range_* attributes that nightly ≥ 1.97 (2026-05-03) now reserves for compiler-internal use, causing a compile error and breaking the fuzz CI job. Pin to 0.13.1 and drop --locked so cargo resolves fresh deps and picks up a compatible rustix version. Mirrors the same fix applied in composefs-rs (commit 7c9a927f). Assisted-by: OpenCode (claude-sonnet-4-6@default) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
handle-archive-records
branch
from
8a7e2df to
b80d676
Compare
jeckersb
approved these changes
May 7, 2026
jeckersb
left a comment
jeckersb
left a comment
There was a problem hiding this comment.
Doesn't appear this repo is currently configured to require 👍 but 👍 nonetheless!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref https://github.com/composefs/composefs-rs#290
GNU tar and Python's tarfile both pad archives to a record boundary (default 20×512 = 10,240 bytes) after the two mandatory end-of-archive zero blocks. Previously ParseEvent::End only reported consumed: 2×512, leaving the trailing padding bytes unaccounted for.
Normally this doesn't even matter, because callers will only be interested in parsing the stream and discarding the underlying bytes. But composefs wants to do a "splitstream" which preserves those bytes.
Assisted-by: OpenCode (claude-sonnet-4-6@default)